[Security] Fix command injection in tree-kill.ts on Windows#7496
[Security] Fix command injection in tree-kill.ts on Windows#7496gonzaloriestra wants to merge 1 commit into
Conversation
- Validate PID format using a strict numeric regex to prevent injection. - Switch from `exec` to `execFile` for Windows taskkill to avoid shell evaluation. - Add comprehensive tests for tree-kill logic. - Perform knip maintenance on root package.json.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Why is this change occurring?
A command injection vulnerability was identified in
packages/cli-kit/src/public/node/tree-kill.tson Windows. The original code usedexecwith unsanitized PID input, allowing an attacker to execute arbitrary commands by providing a malicious PID string (e.g.,123 & calc). Additionally,Number.isNaN()was incorrectly used to validate the PID string, as it returnsfalsefor non-numeric strings without coercion.How to test your changes?
A new test file
packages/cli-kit/src/public/node/tree-kill.test.tshas been added to verify that non-numeric PIDs are rejected and that numeric PIDs are correctly passed toexecFile.Run the tests with:
pnpm --filter @shopify/cli-kit vitest run src/public/node/tree-kill.test.tsDuplicate check
git log --grep="Security" --grep="tree-kill" --grep="win32" --onelinetree-kill.tshas not been addressed before.Jules Label
The
Juleslabel is mandatory for this PR.PR created automatically by Jules for task 12728275771617467983 started by @gonzaloriestra