[Performance] Optimize Liquid template rendering#7475
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
0853927 to
8bb6c8e
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260506091709Caution After installing, validate the version by running |
craigmichaelmartin
left a comment
There was a problem hiding this comment.
The new includes check is a behavioral change. Lets add tests for this short-circuit path.
8bb6c8e to
39bdd75
Compare
- Reuse Liquid engine instance via shared singleton - Add fast-path for static strings without Liquid tags - Static strings are ~480x faster, templates ~3x faster
39bdd75 to
ff6b72d
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
WHY are these changes introduced?
The
renderLiquidTemplatefunction in@shopify/cli-kitwas creating a newLiquidinstance on every invocation, which is expensive due to engine initialization. It also parsed and rendered every string regardless of whether it contained actual Liquid templates.WHAT is this pull request doing?
Liquidengine instance.includesto skip parsing/rendering for strings without{{or{%.Performance Impact (1000 iterations):
How to test your changes?
Verify that Liquid rendering still works correctly by running the unit tests:
pnpm --filter @shopify/cli-kit vitest run src/public/node/liquid.test.tsChecklist
patch) and added a changeset.PR created automatically by Jules for task 9657811168130259180 started by @gonzaloriestra