Skip to content

[Security] Add command safety check to execCommand#7462

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
sentinel-execcommand-safety-8108638445474048430
Closed

[Security] Add command safety check to execCommand#7462
gonzaloriestra wants to merge 1 commit into
mainfrom
sentinel-execcommand-safety-8108638445474048430

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

execCommand was missing a security check that other command execution utilities in @shopify/cli-kit had. Specifically, it didn't verify if the binary was located in the current working directory, which could lead to PATH hijacking vulnerabilities.

WHAT is this pull request doing?

  • Modifies execCommand in packages/cli-kit/src/public/node/system.ts to call checkCommandSafety.
  • Uses parseCommand to extract the binary name from the command string.
  • Adds a unit test in packages/cli-kit/src/public/node/system.test.ts to verify the fix.
  • Adds security-focused documentation to checkCommandSafety.

How to test your changes?

Run the unit tests for cli-kit:
pnpm --filter @shopify/cli-kit vitest run src/public/node/system.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 8108638445474048430 started by @gonzaloriestra

Ensure that execCommand validates that the binary is not located in the current working directory, preventing PATH hijacking. Added security-focused comments and unit tests.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant