Fix release workflow by removing oclif manifest generation for some packages#7455
Merged
Merged
Conversation
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260504080446Caution After installing, validate the version by running |
alfonso-noriega
approved these changes
May 4, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The releases started failing when publishing
@shopify/plugin-cloudflarewithCannot find package '@oclif/plugin-legacy' imported from .../oclif/lib/commands/manifest.js. Example.Root cause: #7159 added
pnpm oclif manifestto theprepackof every package listingoclif.manifest.json. But some of them don't declare anoclifconfig block and the command fails. They don't need the manifest.WHAT is this pull request doing?
For the five packages without an
oclifconfig block, dropspnpm oclif manifestfrom theirprepackscript and removes the dead"/oclif.manifest.json"entry from theirfilesarrayHow to test your changes?
#7455 (comment)
Checklist
pnpm changeset add