Skip to content

Fix release workflow by removing oclif manifest generation for some packages#7455

Merged
gonzaloriestra merged 1 commit into
mainfrom
fix-snapit-oclif-manifest-prepack
May 4, 2026
Merged

Fix release workflow by removing oclif manifest generation for some packages#7455
gonzaloriestra merged 1 commit into
mainfrom
fix-snapit-oclif-manifest-prepack

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 4, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The releases started failing when publishing @shopify/plugin-cloudflare with Cannot find package '@oclif/plugin-legacy' imported from .../oclif/lib/commands/manifest.js. Example.

Root cause: #7159 added pnpm oclif manifest to the prepack of every package listing oclif.manifest.json. But some of them don't declare an oclif config block and the command fails. They don't need the manifest.

WHAT is this pull request doing?

For the five packages without an oclif config block, drops pnpm oclif manifest from their prepack script and removes the dead "/oclif.manifest.json" entry from their files array

How to test your changes?

#7455 (comment)

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 4, 2026
@gonzaloriestra

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260504080446

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 4, 2026 08:12
@gonzaloriestra gonzaloriestra requested review from a team as code owners May 4, 2026 08:12

gonzaloriestra commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 4, 10:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 4, 10:17 AM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 4, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 4, 2026
@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 93f0225 May 4, 2026
30 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-snapit-oclif-manifest-prepack branch May 4, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants