Skip to content

[Refactor] Use relativePath utility in copyDirectoryContents#7440

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-copy-directory-contents-12107833890165445825
Closed

[Refactor] Use relativePath utility in copyDirectoryContents#7440
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-copy-directory-contents-12107833890165445825

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

This PR refactors the copyDirectoryContents function in the cli-kit package to improve its readability and robustness.

  • Replaced manual .replace() calls with the relativePath utility for consistent path calculation.
  • Switched from an imperative loop with an array push to a more idiomatic .map() for collecting file-copy promises.
  • Avoided variable shadowing by using relPath as the local variable name.

Verified with existing tests in packages/cli-kit/src/public/node/fs.test.ts.


PR created automatically by Jules for task 12107833890165445825 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 1, 2026
Refactored `copyDirectoryContents` in `packages/cli-kit/src/public/node/fs.ts` to use the `relativePath` utility instead of manual string manipulation for more robust and idiomatic path handling. Also simplified the promise collection by using `.map()`.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gonzaloriestra gonzaloriestra force-pushed the refactor-copy-directory-contents-12107833890165445825 branch from 997fd1a to 9c19e7f Compare May 4, 2026 08:24
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 4, 2026 08:30
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 4, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant