Fix tests-pr workflow skipping in merge queue#7421
Merged
isaacroldan merged 1 commit intoApr 29, 2026
Conversation
github-actions
Bot
added
the
no-changelog
isaacroldan
force-pushed
the
04-29-fix_tests-pr_workflow_skipping_in_merge_queue
branch
from
c22dc2f to
82bdd4b
Compare
The `head.repo.full_name == github.repository` guard evaluates to false in `merge_group` events, since `github.event.pull_request` is null there. Allow non-PR events through and only gate fork PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
04-29-fix_tests-pr_workflow_skipping_in_merge_queue
branch
from
82bdd4b to
3a955c4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR test workflow so the E2E test job no longer gets skipped when the workflow runs under GitHub’s merge queue (merge_group), which helps keep required checks consistent for merge-queue merges.
Changes:
- Allow the
e2e-testsjob to run formerge_groupevents in addition to same-repo PRs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gonzaloriestra
approved these changes
Apr 29, 2026
isaacroldan
deleted the
04-29-fix_tests-pr_workflow_skipping_in_merge_queue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
e2e-testsjob intests-pr.ymlis gated bygithub.event.pull_request.head.repo.full_name == github.repository. Inmerge_groupevents thepull_requestobject doesn't exist, so that expression evaluates to an empty string and the job is silently skipped — which makes it unsuitable as a required check for the merge queue.WHAT is this pull request doing?
Updates the guard on
e2e-teststo:This allows the job to run in the merge queue while still skipping fork PRs (which can't access the E2E secrets).
type-diffis intentionally left as-is — it's not needed in the merge queue.How to test your changes?
E2E testsruns.merge_groupevents from the queue.