Fix App Management API app-not-found error message (shop/issues-develop#226)

[isaacroldan]

WHY are these changes introduced?

Fixes shop/issues-develop#226

When shopify app config link --client-id=<unknown> is run against a Dev Dashboard (App Management) app, the CLI crashed with a TypeError: Cannot read properties of null (reading 'activeRelease') stack trace, instead of the friendly "No app with client ID … found" abort that Partners apps already surface. The underlying GraphQL appByKey query returns null (HTTP 200) when the client ID does not exist, but AppManagementClient.appFromIdentifiers was destructuring the result unconditionally.

WHAT is this pull request doing?

• packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts: return undefined when appByKey resolves to null, mirroring PartnersClient. The caller in services/context.ts then renders the existing abort error.
• Added two unit tests covering the null-app and happy-path branches of appFromIdentifiers.
• Patch changeset for @shopify/app.

How to test your changes?

1. Check out this branch and pnpm build it.
2. From any app directory, run:

   shopify app config link --client-id=does-not-exist
   

   against a Dev Dashboard organization (App Management).
3. Expect a clean "No app with client ID …" abort message — no stack trace.

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've considered analytics changes to measure impact
• The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

[isaacroldan]

• Fix App Management API app-not-found error message (shop/issues-develop#226) #7403 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR prevents a null-dereference when resolving an app by client ID through the App Management API, enabling upstream code to surface the intended “app not found” friendly error instead of a stack trace.

Changes:

• Return undefined from AppManagementClient.appFromIdentifiers when the API returns app: null.
• Add unit tests covering both “not found” and “found” cases for appFromIdentifiers.
• Add a changeset to ship the user-facing fix as a patch.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts	Adds a guard for app: null to avoid crashing and allow upstream friendly messaging.
packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts	Adds coverage ensuring appFromIdentifiers returns undefined on missing app and returns the mapped app when present.
.changeset/handle-app-management-app-not-found.md	Declares a patch release note for the improved “client ID not found” experience.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[amcaplan]

I'm not seeing the originally complained about behavior...

in cli/ on main 
› SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 pnpm -s shopify:run app config link --path ~/dev/experiments/lean-supply-app --client-id abcdefg
╭─ error ────────────────────────────────────────────────────────────────────────╮
│                                                                                │
│  No app with client ID `abcdefg` found                                         │
│                                                                                │
│  Next steps:                                                                   │
│    • Check that your account has permission to develop apps for this           │
│      organization or contact the owner of the organization to grant you        │
│      permission                                                                │
│    • Run `shopify auth login` to log into a different account than             │
│      ariel.caplan@shopify.com                                                  │
│    • Pass `--reset` to your command to create a new app                        │
│                                                                                │
╰────────────────────────────────────────────────────────────────────────────────╯

[isaacroldan]

This is an old issue, seems like this is currently throwing and being cached somewhere else.
But the fix still makes sense, app could be undefined, so we shouldn't try to do app.activeRelease without checking. Is safer to return undefined here