E2E: replace npm with pnpm#7333
Merged
Merged
Conversation
isaacroldan
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the E2E test suite to use pnpm instead of npm when scaffolding apps, aligning local E2E runs with Shopify’s internal dev environment where npm install is unsupported.
Changes:
- Switched
createApp({ packageManager: 'npm' })tocreateApp({ packageManager: 'pnpm' })in key E2E specs. - Updated the E2E CLI timeout comment to remove the specific
npm installreference.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/e2e/tests/app-scaffold.spec.ts | Uses pnpm for app creation across scaffold scenarios. |
| packages/e2e/tests/app-dev-server.spec.ts | Uses pnpm for app creation before running app dev. |
| packages/e2e/tests/app-deploy.spec.ts | Uses pnpm for app creation before app deploy verification. |
| packages/e2e/setup/constants.ts | Updates timeout documentation to be package-manager agnostic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
E2E tests hardcoded
packageManager: 'npm'in allcreateAppcalls. npm is no longer supported in Shopify's internal dev environment (npm installfails with "npm is no longer supported in a global context. Please migrate to pnpm"). This blocks local test runs.WHAT is this pull request doing?
packageManagerfrom'npm'to'pnpm'acrossapp-scaffold,app-deploy, andapp-dev-serverspecsconstants.tsto remove the npm referenceNo test behavior changes — the tests exercise the same CLI commands (
app init,app build,app dev,app deploy), just with pnpm handling dependency installation instead of npm.How to test your changes?
Checklist
pnpm changeset add