Skip to content

E2E: replace npm with pnpm#7333

Merged
phyllis-sy-wu merged 1 commit into
mainfrom
psyw-0416-E2E-replace-npm-with-pnpm
Apr 16, 2026
Merged

E2E: replace npm with pnpm#7333
phyllis-sy-wu merged 1 commit into
mainfrom
psyw-0416-E2E-replace-npm-with-pnpm

Conversation

@phyllis-sy-wu

@phyllis-sy-wu phyllis-sy-wu commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

E2E tests hardcoded packageManager: 'npm' in all createApp calls. npm is no longer supported in Shopify's internal dev environment (npm install fails with "npm is no longer supported in a global context. Please migrate to pnpm"). This blocks local test runs.

WHAT is this pull request doing?

  • Switches all E2E test packageManager from 'npm' to 'pnpm' across app-scaffold, app-deploy, and app-dev-server specs
  • Updates a comment in constants.ts to remove the npm reference

No test behavior changes — the tests exercise the same CLI commands (app init, app build, app dev, app deploy), just with pnpm handling dependency installation instead of npm.

How to test your changes?

DEBUG=1 pnpm --filter e2e exec playwright test

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@phyllis-sy-wu phyllis-sy-wu marked this pull request as ready for review April 16, 2026 16:18
@phyllis-sy-wu phyllis-sy-wu requested a review from a team as a code owner April 16, 2026 16:18
Copilot AI review requested due to automatic review settings April 16, 2026 16:18
@phyllis-sy-wu phyllis-sy-wu enabled auto-merge April 16, 2026 16:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the E2E test suite to use pnpm instead of npm when scaffolding apps, aligning local E2E runs with Shopify’s internal dev environment where npm install is unsupported.

Changes:

  • Switched createApp({ packageManager: 'npm' }) to createApp({ packageManager: 'pnpm' }) in key E2E specs.
  • Updated the E2E CLI timeout comment to remove the specific npm install reference.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/e2e/tests/app-scaffold.spec.ts Uses pnpm for app creation across scaffold scenarios.
packages/e2e/tests/app-dev-server.spec.ts Uses pnpm for app creation before running app dev.
packages/e2e/tests/app-deploy.spec.ts Uses pnpm for app creation before app deploy verification.
packages/e2e/setup/constants.ts Updates timeout documentation to be package-manager agnostic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@phyllis-sy-wu phyllis-sy-wu added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 9e41617 Apr 16, 2026
39 of 50 checks passed
@phyllis-sy-wu phyllis-sy-wu deleted the psyw-0416-E2E-replace-npm-with-pnpm branch April 16, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants