Skip to content

fix: add error handling to empty catch blocks#7283

Closed
alfonso-noriega wants to merge 1 commit into
mainfrom
01-fix-empty-catch-blocks
Closed

fix: add error handling to empty catch blocks#7283
alfonso-noriega wants to merge 1 commit into
mainfrom
01-fix-empty-catch-blocks

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@github-actions

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

The empty catch block in app-logs-polling.ts silently swallowed all
errors during app logs setup, making failures invisible to developers.

Added outputDebug logging so errors are captured in debug output
instead of being silently discarded.
@gonzaloriestra gonzaloriestra force-pushed the 01-fix-empty-catch-blocks branch from 3a69a9a to fb3eac1 Compare May 20, 2026 13:12
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 20, 2026
@github-actions github-actions Bot closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. no-pr-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant