Skip to content

Fix release script inconsistency#7207

Merged
dmerand merged 1 commit into
mainfrom
dlm-fix-notification-post-release
Apr 7, 2026
Merged

Fix release script inconsistency#7207
dmerand merged 1 commit into
mainfrom
dlm-fix-notification-post-release

Conversation

@dmerand

@dmerand dmerand commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

What

Fix pnpm post-release so it can create the notification PR consistently.

Why

During the 3.93.1 patch release, post-release created the homebrew and docs PRs but failed on the notification step. bin/create-notification-pr.js was executed by bash instead of Node, which produced misleading import output and a shell syntax error.

How

  • add the missing Node shebang to bin/create-notification-pr.js
  • invoke the post-release helper scripts with node ... instead of relying on direct execution

Testing

From a clean stable/3.x checkout, run:

pnpm post-release

Verify that:

  • the homebrew PR step runs
  • the docs PR step runs
  • the notification PR step runs without shell parse errors

dmerand commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dmerand dmerand marked this pull request as ready for review April 6, 2026 20:10
@dmerand dmerand requested a review from a team as a code owner April 6, 2026 20:10
Copilot AI review requested due to automatic review settings April 6, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@craigmichaelmartin craigmichaelmartin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmerand dmerand added this pull request to the merge queue Apr 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026
@dmerand dmerand added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit de45230 Apr 7, 2026
24 of 25 checks passed
@dmerand dmerand deleted the dlm-fix-notification-post-release branch April 7, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants