Refactor RemoteSpecification by isaacroldan · Pull Request #7111 · Shopify/cli

isaacroldan · 2026-03-26T12:03:23Z

Simplify types and transformations of specification definitions:

Made RemoteSpecification a flatten generic object.
Added PartnersRemoteSpecification to represent the spec results from Partners (this is to be deprecated with Partners)
Removed FlattenedRemoteSpecification
Transform from PartnersRemoteSpecification to RemoteSpecification and not the other way around.
Simplify logic for handleInvalidAdditionalProperties now only strip for configuration modules.

isaacroldan · 2026-03-26T12:03:41Z

Refactor RemoteSpecification #7111 👈 (View in Graphite)
feat: fetch experience field from API instead of hardcoding it #7079 : 2 other dependent PRs (#7109 , #7110 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-26T12:34:41Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	82.31%	15127/18378
🟡	Branches	74.83%	7443/9947
🟢	Functions	81.32%	3801/4674
🟢	Lines	82.7%	14303/17295

Test suite run success

4000 tests passing in 1531 suites.

Report generated by 🧪jest coverage report action from 1039df1

Bumps [yaml](https://github.com/eemeli/yaml) from 2.7.0 to 2.8.3. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.7.0...v2.8.3) --- updated-dependencies: - dependency-name: yaml dependency-version: 2.8.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the nx group with 1 update in the / directory: [nx](https://github.com/nrwl/nx/tree/HEAD/packages/nx). Updates `nx` from 22.5.4 to 22.6.1 - [Release notes](https://github.com/nrwl/nx/releases) - [Commits](https://github.com/nrwl/nx/commits/22.6.1/packages/nx) --- updated-dependencies: - dependency-name: nx dependency-version: 22.6.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: nx ... Signed-off-by: dependabot[bot] <support@github.com>

First pass, not final agent shape

When the JWT for app log polling expires, handleFetchAppLogsError calls onResubscribe() to get a fresh token. If onResubscribe() itself throws (network error, expired session), the exception propagates unhandled, causing the dev polling loop to retry every 5s with the same expired JWT — an infinite 401 loop. Wrap onResubscribe() in a try-catch so failures fall back to a 60s retry interval instead of propagating. This is a 12x reduction in 401 rate per affected client and allows self-healing when the underlying issue resolves.

github-actions · 2026-03-27T18:24:46Z

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copilot

Pull request overview

Refactors how extension specifications are represented and merged by introducing a flattened RemoteSpecification shape, aligning both Partners and App Management clients to return that shape, and simplifying downstream merging/validation behavior.

Changes:

Introduces a flattened RemoteSpecification type and updates Partners/App Management clients to return it.
Refactors spec fetching/merging to work with the flattened remote shape and simplifies additional-properties handling based on experience.
Updates local contract-based spec creation to accept experience, and adjusts test fixtures to match the new remote spec shape.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/app/src/cli/utilities/json-schema.ts	Updates unified parser factory signature to accept validation schema separately from the merged spec.
packages/app/src/cli/utilities/developer-platform-client/partners-client.ts	Maps Partners API spec shape into flattened `RemoteSpecification` (derives `uidStrategy`, hoists fields).
packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts	Emits flattened `RemoteSpecification`; updates `uidStrategyFromTypename` to always return a strategy.
packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts	Updates unit test to reflect new default behavior for unknown uid strategy typenames.
packages/app/src/cli/services/generate/fetch-extension-specifications.ts	Refactors remote/local merge logic for flattened specs; changes additionalProperties stripping rules.
packages/app/src/cli/services/generate/fetch-extension-specifications.test.ts	Updates expectations to align with new merged spec shape.
packages/app/src/cli/models/extensions/specifications/channel.ts	Provides explicit `uidStrategy` and `experience` when building a contract-based spec.
packages/app/src/cli/models/extensions/specification.ts	Extends `createContractBasedModuleSpecification` input to include `experience` and forwards it through.
packages/app/src/cli/models/app/app.test-data.ts	Updates test remote specification fixtures to the flattened shape (hoists options/features-derived fields).
packages/app/src/cli/api/graphql/extension_specifications.ts	Introduces flattened `RemoteSpecification` type; adds `PartnersRemoteSpecification` for Partners query shape.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ryancbahan

nice refactor. i've been thinking about this area lately -- i'd love for us to get remotespec and extension instance to be much lighter representations of the data itself, with commands owning the behaviors they need rather than threading them on the spec/instance. curious if this aligns/misaligns with your thinking?

isaacroldan · 2026-03-31T16:00:05Z

Aligned on making the specs/extension instance lighter, but not sure I see how the commands would own the behaviours they need for each extension type :thinking_face: Some behaviours are shared (like validation or building)

ryancbahan · 2026-03-31T16:06:04Z

@isaacroldan shared, composable utils per-domain, backed by registries, is what i imagine

This was referenced Mar 26, 2026

feat: fetch experience field from API instead of hardcoding it #7079

Merged

refactor: make RemoteAwareExtensionSpecification type-safe by including remote fields and using a builder function #7109

Closed

isaacroldan mentioned this pull request Mar 26, 2026

refactor: flatten RemoteSpecification options to align with ExtensionSpecification #7110

Closed

5 tasks

isaacroldan force-pushed the 03-26-refactor_remotespecification branch from 2a55801 to 10cf614 Compare March 26, 2026 12:07

isaacroldan force-pushed the 03-23-feat_fetch_experience_field_from_api_instead_of_hardcoding_it branch from e123eb9 to c539bc0 Compare March 26, 2026 12:12

isaacroldan force-pushed the 03-26-refactor_remotespecification branch from 10cf614 to e55dc00 Compare March 26, 2026 12:12

Base automatically changed from 03-23-feat_fetch_experience_field_from_api_instead_of_hardcoding_it to main March 26, 2026 12:24

Refactor RemoteSpecification

0c990bc

isaacroldan force-pushed the 03-26-refactor_remotespecification branch from e55dc00 to 0c990bc Compare March 26, 2026 12:30

dependabot Bot and others added 9 commits March 27, 2026 15:49

--json -j should not use color

203c7ac

Add --json to validate

cb30aed

First pass, not final agent shape

address feedback

fe0648a

stop trying to resubscribe after max attempts

c6a3af2

more fixes

f66f48f

address comment

c65a05b

isaacroldan force-pushed the 03-26-refactor_remotespecification branch 3 times, most recently from f2da66b to a99bc03 Compare March 27, 2026 18:18

isaacroldan marked this pull request as ready for review March 27, 2026 18:24

isaacroldan requested a review from a team as a code owner March 27, 2026 18:24

Copilot AI review requested due to automatic review settings March 27, 2026 18:24

Copilot started reviewing on behalf of isaacroldan March 27, 2026 18:25 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Comment thread packages/app/src/cli/utilities/json-schema.ts

Comment thread packages/app/src/cli/services/generate/fetch-extension-specifications.ts Outdated

Comment thread packages/app/src/cli/services/generate/fetch-extension-specifications.ts Outdated

Refactor RemoteSpecification

9205739

isaacroldan force-pushed the 03-26-refactor_remotespecification branch from a99bc03 to 9205739 Compare March 27, 2026 18:39

isaacroldan added 2 commits March 27, 2026 19:50

Apply suggestions from code review

1039df1

Merge branch 'main' into 03-26-refactor_remotespecification

707e8c2

ryancbahan approved these changes Mar 31, 2026

View reviewed changes

isaacroldan added this pull request to the merge queue Mar 31, 2026

Merged via the queue into main with commit 8675dae Mar 31, 2026
26 checks passed

isaacroldan deleted the 03-26-refactor_remotespecification branch March 31, 2026 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor RemoteSpecification#7111

Refactor RemoteSpecification#7111
isaacroldan merged 13 commits into
mainfrom
03-26-refactor_remotespecification

isaacroldan commented Mar 26, 2026 •

edited

Loading

Uh oh!

isaacroldan commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryancbahan left a comment

Uh oh!

isaacroldan commented Mar 31, 2026

Uh oh!

ryancbahan commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

isaacroldan commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isaacroldan commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryancbahan left a comment

Choose a reason for hiding this comment

Uh oh!

isaacroldan commented Mar 31, 2026

Uh oh!

ryancbahan commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isaacroldan commented Mar 26, 2026 •

edited

Loading

isaacroldan commented Mar 26, 2026 •

edited

Loading

github-actions Bot commented Mar 26, 2026 •

edited

Loading