Some small fixes#9
Open
bentideswell wants to merge 1 commit intoShiptheory:masterfrom
bentideswell:SmallFixes
Open
Some small fixes#9bentideswell wants to merge 1 commit intoShiptheory:masterfrom bentideswell:SmallFixes
bentideswell wants to merge 1 commit intoShiptheory:masterfrom
bentideswell:SmallFixes
Conversation
|
@mikkelson Why the repo is abandoned? |
Member
|
@bentideswell Thank you for these fixes, sorry we've not got round merging yet. We still to test this across all support versions, I'll see if we can get this done next week. @MageSuper It's not abandoned, but it has taken less significance since the release of Magento 2 and especially since the end of support for Magento 1 announcement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains 2 fixes:
The first fix wraps the prepareShipment parameter in an array. Magento requires this to be an array so just passing the ID triggers a warning. This breaks functionality if errors aren't hidden.
Moved the sales order grid action label to it's own method rather than a hard coded string. This makes it easy for devs to modify this without having to rewrite the whole observer.