fix: resolve Clippy 1.94 lint errors in shell-primitives and shell-mempool#5
Merged
LucienSong merged 2 commits intomainfrom Mar 23, 2026
Merged
Conversation
- codec.rs: use `.is_multiple_of(4)` instead of `% 4 != 0` - ssz.rs: use `.div_ceil(32)` instead of `(len + 31) / 32` - admission.rs: derive Default instead of manual impl Co-authored-by: LucienSong <44640337+LucienSong@users.noreply.github.com> Agent-Logs-Url: https://github.com/ShellDAO/shell-chain/sessions/af5db72b-530b-48e9-bab9-a5fdc7f88dc6
Copilot
AI
changed the title
[WIP] Fix PR review lint failures in pull request 4
fix: resolve Clippy 1.94 lint errors in shell-primitives and shell-mempool
Mar 23, 2026
Copilot stopped work on behalf of
LucienSong due to an error
March 23, 2026 02:26
11 tasks
LucienSong
added a commit
to LucienSong/shell-chain
that referenced
this pull request
Mar 25, 2026
…t-failed [WIP] Fix PR review lint failures in pull request 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix three Clippy 1.94 lint errors that fail the
Lint CheckCI job on PR #4 (-D warningspromotes these to hard errors).codec.rs:207—clippy::manual_is_multiple_of:% 4 != 0→.is_multiple_of(4)ssz.rs:62—clippy::manual_div_ceil:(len + 31) / 32→.div_ceil(32)admission.rs—clippy::derivable_impls: manualDefaultimpl →#[derive(Default)]Type of Change
Checklist
cargo fmtpasses)cargo clippy -- -D warningspasses)cargo testpasses)cargo doc --no-depspasses)feat:,fix:,chore:)Related Issues
Resolves lint failures from #4
Additional Notes
All three are new lints in Clippy 1.94 that flag idiomatic stdlib alternatives to manual arithmetic patterns. Semantics are unchanged.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.