fix(deploy): include devDependencies in npm ci and increase health check timeout#458
Open
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Open
fix(deploy): include devDependencies in npm ci and increase health check timeout#458DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Conversation
…eck timeout - Change npm ci --silent to npm ci --include=dev to ensure vue-tsc and other devDependencies are installed (needed for build step) - Increase health check sleep from 5s to 20s to allow orchestrator sufficient startup time Fixes ShaerWare#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #359 where
npm ci --silentfails to install devDependencies whenNODE_ENV=productionis set in the environment.Changes
vue-tscand other build tools are installedProblem
When
NODE_ENV=productionis set,npm ciskips devDependencies. Sincevue-tscis listed in devDependencies but is required for the build step (npm run build), the deploy fails with:Solution
Using
npm ci --include=devensures devDependencies are always installed regardless of NODE_ENV.Fixes #359