fix(ROG Ally): invert gyro yaw for deck-uhid target#607
Open
lonsdaleite wants to merge 1 commit into
Open
Conversation
ROG Ally devices report gyro yaw with the opposite sign from what hid-steam expects when using the deck-uhid target. Enable yaw inversion only on known Ally DMI board names (RC71L, RC72LA, RC73XA, RC73YA).
Contributor
|
This makes no sense to me. There are three distinct possibilities for this:
Given that SteamOS officially released on the Go S and was validated by Valve, and that it has been tested as 1:1 compatible with the deck as a source device, I think it's much more likely that 1 and 3 are more likely. |
Author
|
I didn't update Ally's matrix because I checked ds5 emulation and it worked correctly. But I definitely didn't think that maybe there are two problems exist simultaneously (1 and 3 from your message). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inverted gyro yaw (left/right rotation) on ASUS ROG Ally devices when using the
deck-uhidtarget.Problem
On ROG Ally / Ally X / Xbox Ally, gyro yaw is reversed with
deck-uhidcompared tods5-edge. The IMU source is fine; the mismatch is in how yaw is written to the Deck UHID report versus how hid-steam exposes it as ABS_RZ.Changes
invert_gyro_yawtoSteamDeckConfigsteam_deck_uhidRC71L,RC72LA,RC73XA,RC73YA(from the existing50-rog_*.yamlprofiles). This avoids affecting other handhelds that also use a BMI323 IIO source (e.g. Ayaneo). Detection uses runtime DMIboard_name, so it still applies when the composite profile name is changed for controller spoofing.Test plan
deck-uhidtargetinputplumber device 0 testds5-edgetarget (yaw direction matches)