Add readable endpoint to fetch a resource by ID#4
Merged
Conversation
Introduce ReadableEndpointInterface and ReadableEndpointTrait providing getById() (GET /{endpoint}/{id}), and wire it into the sales orders endpoint. Also add Client::setDebug() to target the sandbox API host.
loevgaard
force-pushed
the
add-readable-endpoint
branch
from
716500b to
e679010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readableendpoint capability following the existing trait-per-verb pattern (Creatable/Deletable):ReadableEndpointInterface+ReadableEndpointTraitexposegetById(int $id)which doesGET /{endpoint}/{id}and maps the response into the endpoint's DTO.$client->salesOrders()->getById(123)now works.Client::setDebug(bool)to switch the base URI between the production host (app.shipmondo.com) and the sandbox host (sandbox.shipmondo.com).LiveClientTest: replace the scratch webhook tests with agetByIdsmoke test that asserts the returned sales order id, and drop the now-unused imports.Test plan
composer check-style— cleancomposer analyse(Psalm) — no errorscomposer phpunit— 25 tests pass (the liveit_fetches_sales_ordertest is gated behindSHIPMONDO_LIVE)