Allowing to use the same input for PromotionCoupon and GiftCards#92
Open
Allowing to use the same input for PromotionCoupon and GiftCards#92
Conversation
loevgaard
requested changes
Aug 10, 2020
Member
loevgaard
left a comment
loevgaard
left a comment
There was a problem hiding this comment.
I think you should come up with a solution where you use different classes for the two scenarios (with and without using same input for coupon and gift card). I think this will make it much cleaner.
This means a form for both scenarios, a controller etc. Right now I think the controller for example is too complex
|
hello, could it be merged? |
it would be nice :) |
Contributor
Author
|
Hey there. There is still some work to do on this matter to simplify things and make it easier to read/extend. But this issue is in my TODO and it should be dealt with in the upcoming weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59