examples: remove streaming + native player from the DHT channels demo#25
Merged
Merged
Conversation
The native OXT player playback did not work in practice and is unlikely to, so remove the whole streaming feature rather than ship a broken button: - Drop the player overlay (chPlayer / chStreamBar / chCloseStream) and the "Stream Selected" button from chBuild. - Remove chStreamSelected, chOpenPlayer, chCloseStream, chMediaKind, and chMainMediaFile, the sHasPlayer state, the mouseUp cases, the tooltips, and the streaming lines in the header doc + in-app help. The file-detail panel (btFileList: name, size, live per-file progress bar) stays - it works and is the point of clicking a transfer. With the Stream button gone, its caption goes full-width and the file list grows into the reclaimed space, keeping the two-column 720p layout clean and balanced. Examples only - no shim/ABI change. Verified statically (tools/check-livecodescript.py: 5 files OK); needs an OXT pass for the look. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01371AXB4CUUke7enHHS8okc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native OXT
playerplayback in the channels demo did not work in practice and is unlikely to, so this removes the whole streaming feature rather than ship a button that does nothing useful. The two-column 720p layout (which looked good) is preserved.What's removed
chPlayer/chStreamBar/chCloseStream) and the Stream Selected button fromchBuild.chStreamSelected,chOpenPlayer,chCloseStream,chMediaKind,chMainMediaFile; thesHasPlayerstate; themouseUpcases; the tooltips; and the streaming lines in the header doc + in-app help.What stays
btFileList: name, size, live per-file progress bar) — it works and is the reason to click a transfer.Layout
With the Stream button gone, the file-detail caption goes full-width and the file list grows into the reclaimed space (
chFilesnow…342…470), keeping the right column clean and balanced against the left. No control overlaps; still fits 720p.Verification
tools/check-livecodescript.py: 5 files OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01371AXB4CUUke7enHHS8okc
Generated by Claude Code