Check for direct string in widget html template - healthscan finding#2301
Closed
raghavs046 wants to merge 6 commits intoServiceNowDevProgram:mainfrom
Closed
Check for direct string in widget html template - healthscan finding#2301raghavs046 wants to merge 6 commits intoServiceNowDevProgram:mainfrom
raghavs046 wants to merge 6 commits intoServiceNowDevProgram:mainfrom
Conversation
…ML Templates -HealthScan Finding directory
Contributor
|
Thanks again for the submission! While the initial idea is valid, the current implementation is quite minimal and doesn’t introduce enough unique script logic or scenarios beyond what’s already covered in the repo. Since similar patterns already exist and this doesn’t add much new value, Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This BR will help to avoid healthscan finding arising out of string directly added to HTML templates.
This BR will run on insert/update of widget when HTML changes and check if direct string are added which will not be translated.
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions