improved read me to activeGroupsWithoutMembers#2297
Closed
ChaseMillers wants to merge 1 commit intoServiceNowDevProgram:mainfrom
ChaseMillers:update-fetch-active-groups-readme
Closed
improved read me to activeGroupsWithoutMembers#2297ChaseMillers wants to merge 1 commit intoServiceNowDevProgram:mainfrom ChaseMillers:update-fetch-active-groups-readme
ChaseMillers wants to merge 1 commit intoServiceNowDevProgram:mainfrom
ChaseMillers:update-fetch-active-groups-readme
Conversation
Contributor
ravichandra1998g
left a comment
There was a problem hiding this comment.
Hello @ChaseMillers
Thank you for your efforts in updating the README file.
That PR was a low-effort one, and the code itself was quite simple, using GlideAggregate. While the detailed README you added was certainly helpful, those simple lines were sufficient as well for a simple code.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
I only updated the README.mb file linked to the activeGroupsWithoutMembers.js file.
This new README.md explains more about what the actual .js file does as well as how to use.
The .js code itself doesn't have many comments to explain, so this change seemed helpful and appropriate.
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions