Refactor email validation regex to RFC 5322-compliant implementation#2126
Merged
Atul-LNG merged 1 commit intoServiceNowDevProgram:mainfrom Oct 14, 2025
Conversation
Atul-LNG
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR refactors the email validation logic in the repository to use a more comprehensive regex that aligns with common RFC 5322 patterns and stricter domain rules.
Changes Include
Replaced the old simple regex with a new RFC 5322-based regex.
Added support for:
"john.doe"@example.com)user@[192.168.0.1])Updated
README.mdto reflect the refactored implementation and examples.Added test cases for both common valid and invalid email formats.
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions