Delete duplicate: Client-Side Components/Catalog Client Script/Allow 10digit Fax…#2063
Merged
ivan-betev merged 1 commit intoServiceNowDevProgram:mainfrom Oct 12, 2025
Conversation
… Number directory Remove this Regex, as it is not in the right folder and is a duplicate of a Regex in the regex folder Specialized Areas/Regular Expressions/Check if number has 10 digits. I noticed this when I was refactoring that one.
Contributor
|
Great job! 🗡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Remove this Regex, as it is not in the right folder and is a duplicate of a Regex in the regex folder: Specialized Areas/Regular Expressions/Check if number has 10 digits https://github.com/WillemZeiler/code-snippets/tree/f1f5267a806b39e8c63703f8b4274a850c11448f/Specialized%20Areas/Regular%20Expressions/Check%20if%20number%20has%2010%20digits.
Besides the 10 digit Regex check it does not anything related to fax numbers.
Quick google search got me these formats f.e.:
+CountryCode-AreaCode-LocalNumber
00CountryCode-AreaCode-LocalNumber
(CountryCode) AreaCode-LocalNumber
AreaCode-LocalNumber
(LocalNumber only)
1-800-LocalNumber
1-888-LocalNumber
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions