Background Script - Identify Orphaned Users (with no roles and no groups)#2046
Closed
Shashank102002 wants to merge 4 commits intoServiceNowDevProgram:mainfrom
Closed
Background Script - Identify Orphaned Users (with no roles and no groups)#2046Shashank102002 wants to merge 4 commits intoServiceNowDevProgram:mainfrom
Shashank102002 wants to merge 4 commits intoServiceNowDevProgram:mainfrom
Conversation
Contributor
|
Thanks for your contribution @Shashank102002 . The scripts logic looks fine to me, however, instead of directly getting the value, use of getValue() method would be preferable and less error prone as the other way can lead you to same pointer error in object reference. Once you make those changes. I can merge your request. |
…ps/checking for users with zero groups AND zero roles.js
Contributor
Author
|
@kmohit2809 , Thanks for the feedback! |
Contributor
|
I am not able to see your changes. To me the lines are still same like userRecord.sys_id and all other places where you are getting the value for querying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
replace this with your description
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions