-
Notifications
You must be signed in to change notification settings - Fork 112
Email and Mobile number Regex #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email and Mobile number Regex #113
Conversation
|
✅ Valid PR for ActionPack Thank you for your contribution. This PR complies with the CONTRIBUTING.md. |
Atul-LNG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @naveensnow
Thanks for your participation!
Did you try the dynamic approach — meaning, passing a regex pattern along with a phone number or email as input, and getting a result of pass or fail?
|
Share your thoughts to proceed further @naveensnow |
yes we can do that. do you want me pass regex as input and validate? |
|
@Atul-LNG I have committed new changes with passing input as regex. |
SapphicFire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @Atul-LNG will be able to merge for you soon!
|
Thanks @naveensnow for the updates! I'm glad to see that you changed the approach and made it more dynamic. The code looks good, and we really appreciate your efforts. Please also encourage your colleagues to participate in Hacktoberfest! |
This action contains the validation for valid email and mobile number through regex validation