Update Till.cs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have rewrote the code of addB to DiscountItems and updated AddItemC. Also, in Total() function, I have added a variable 'noOfItemsC' to keep track the maximum number of ItemC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the addB function, I have rewrote the code to calculate the special needed. Basically, I think that we could combine the calculation for Special Item A and B in just one function(DiscountItems) because in general, ItemA and ItemB are similar to calculate. Furthermore, there is no calculation that used to make discount in ItemA.
Also, the function AddItemC isn't checked the maximum number of Items C, so I have updated this function. In the Total() function, I have added a variable that used to check the current number of item C.