Skip to content

Conversation

@WilliamAlkawaz
Copy link

No description provided.

@WilliamAlkawaz
Copy link
Author

  • Input validation is required because we're not sure about user's intent and also to avoid non-meaningful input. This can be achieved by creating a function for each datatype validation with a prompt to show a meaningful message to users.
  • One simple warning in the Order class has been remove.
  • It is always a good practice to use try and catch with meaningful error messages.
  • Encapsulation issue has been resolved. Local variables should be private such as "Triangle Price" and so on.
  • Follow naming convention with variables and methods.
  • Consider use decimal type for price.
  • Class documentation can help other programmers understand the code easily.
  • Finally, unit test has not been found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant