Code Review - Malith B #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nternal unless there is specific reason to make them public. - Consider using chaining constructors :base() in constructors of derived classes to implicitly call the constructor of the base class. - Consider introducing a separate class for global constants like variables and enums Simplify member acces "base.NumberOfRedShape" to "NumberOfRedShape" - Remove unnecessary parentheses - Remove and Sort Usings
… Introduced a new entity called ShapeVariant - Introduced a separate helper file for report generation to avoid code duplication in each report class - Move generic functionalities from derived classes to it's base class
… to avoid lots of code duplication in Program.cs. - Introduced a new option to allow empty inputs - Order.ToString() hides Object.ToString(), so 'override' statement was added. -- TODO : -- User input and sanitization -- Reconsider the project/folder structure -- Unit Tests -- Upgrade target framework as current version is out of support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the findings below :
CodeReview-MalithB.pdf