Refactor and extend target selector parsing logic#195
Open
pyris-dev wants to merge 2 commits intoSerenityJS:mainfrom
Open
Refactor and extend target selector parsing logic#195pyris-dev wants to merge 2 commits intoSerenityJS:mainfrom
pyris-dev wants to merge 2 commits intoSerenityJS:mainfrom
Conversation
Introduces a TargetSelectorQuery enum and refactors the TargetEnum class to support more robust and extensible target selector parsing, including support for additional selector types, query keys, and improved error handling. The new implementation allows for more flexible and maintainable command target resolution.
Removed the TargetSelectorQuery enum and replaced its usage with string literals for selector queries. Extracted repeated distance calculation logic into a new static method, calculateDistance, in TargetEnum for improved code reuse and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a TargetSelectorQuery enum and refactors the TargetEnum class to support more robust and extensible target selector parsing, including support for additional selector types, query keys, and improved error handling. The new implementation allows for more flexible and maintainable command target resolution.