Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to version 0.11.6 by updating dependency paths, moving to Python 3.12, and adding a middleware to block VRT-related requests.
- Updated pyproject.toml files to adjust dependency paths (introducing an extra forward slash).
- Upgraded the Python requirement in the root and AWS Lambda Dockerfile to 3.12.
- Introduced BlockVRTMiddleware to reject requests involving VRT files.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/titiler/mosaic/pyproject.toml | Adjusted dependency path to use an extra forward slash. |
| src/titiler/extensions/pyproject.toml | Adjusted dependency path to use an extra forward slash. |
| src/titiler/core/titiler/core/middleware.py | Added BlockVRTMiddleware to block VRT files. |
| src/titiler/application/titiler/application/main.py | Added BlockVRTMiddleware to the middleware stack (appears twice). |
| src/titiler/application/pyproject.toml | Adjusted dependency paths with an extra forward slash. |
| pyproject.toml | Upgraded Python version requirement to 3.12 and updated dependency paths. |
| dockerfiles/Dockerfile.gunicorn | Commented out removal of temporary files. |
| deployment/aws/lambda/Dockerfile | Updated to Python 3.12 and installed additional system dependencies. |
| LoggerMiddleware, | ||
| LowerCaseQueryStringMiddleware, | ||
| TotalTimeMiddleware, | ||
| BlockVRTMiddleware, |
There was a problem hiding this comment.
BlockVRTMiddleware appears to be added twice to the middleware stack; consider consolidating its registration to a single instance to avoid potential duplicate processing.
| # Configured for volume-mount path of Lambda Dockerfile. For local | ||
| # development, update accordingly for your local filesystem path: | ||
| "titiler.core @ file:///titiler/src/titiler/core", | ||
| "titiler.core @ file:///titiler/src//titiler/core", |
There was a problem hiding this comment.
The dependency path includes an extra forward slash which might be redundant; verify if this is intentional or if it could be standardized to ensure consistency.
| "titiler.core @ file:///titiler/src//titiler/core", | |
| "titiler.core @ file:///titiler/src/titiler/core", |
| RUN python -m pip install -U pip | ||
| RUN python -m pip install /tmp/titiler/core /tmp/titiler/extensions["cogeo,stac"] /tmp/titiler/mosaic /tmp/titiler/application --no-cache-dir --upgrade | ||
| RUN rm -rf /tmp/titiler | ||
| # RUN rm -rf /tmp/titiler |
There was a problem hiding this comment.
[nitpick] The removal of the temporary titiler directory is commented out; clarify whether this is for debugging purposes or if it should be restored for production cleanliness.
| # RUN rm -rf /tmp/titiler | |
| RUN rm -rf /tmp/titiler |
2 participants
No description provided.