Add MAC address to the device_info object in the client hello message#87
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the protocol spec for client/hello to optionally include a MAC address in device_info, enabling servers to better correlate a connection with a physical device.
Changes:
- Documented a new optional
device_info.mac_addressfield forclient/hello. - Specified the expected string representation (lowercase, colon-separated) via an example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maximmaxim345
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
mac_addressfield to thedevice_infoobject inclient/hello. It carries the MAC address of the network interface the connection is opened on, in lowercase colon-separated form, to help identify the physical device.