fix: route repeat/shuffle through ControllerGroupRole in metadata scenario#74
Merged
maximmaxim345 merged 1 commit intoJun 2, 2026
Merged
Conversation
…nario aiosendspin #244 removed repeat and shuffle from MetadataGroupRole.update() — they now live in ControllerGroupRole.set_repeat() / set_shuffle(). The metadata scenario was crashing with 'unexpected keyword argument repeat'. Fix: drop repeat= and shuffle= from metadata_group_role.update(), and call controller_group_role.set_repeat() / set_shuffle() instead. The controller role already mirrors those values back into metadata state for v1 back-compat via _mirror_to_metadata_back_compat(), so clients still receive them in the metadata payload and assertions continue to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
In
_run_metadata_scenario()(src/conformance/adapters/aiosendspin_server.py), removedrepeat=andshuffle=from themetadata_group_role.update()call, and replaced them with calls tocontroller_group_role.set_repeat()andcontroller_group_role.set_shuffle().Why
aiosendspin #244 moved repeat/shuffle state out of
MetadataGroupRole.update()— those parameters no longer exist on that method. Passing them was crashing with:How it works now
ControllerGroupRole.set_repeat()/set_shuffle()call_mirror_to_metadata_back_compat()internally, which writes the values back into the metadata state for v1 client backwards compatibility. Clients still receiverepeatandshufflein the metadata payload, so the client-side assertions in_normalize_metadata_state()and the snapshot comparison inrunner.pycontinue to match without any further changes.Reviewer notes
_metadata_snapshot(), CLI args,scenarios.py, or the client adapter — the expected/received comparison format is unchanged.isinstancecheck) follows the same pattern already used in_run_controller_scenario().