Fix premature sending of the connected state#82
Merged
Conversation
The Cast SDK fires SYSTEM_VOLUME_CHANGED at receiver boot before any SendspinPlayer exists. The handler was sending status with state="connected" alongside the volume payload, which the MA bridge took as proof the Cast app had finished its connect handshake. Any later AudioContext or connection failure was then swallowed because the bridge's cast-ready future was already resolved. Send state="connecting" so the future stays pending until the real "Connected - ready to play" status fires after AudioContext is verified and the WebSocket connect succeeds.
There was a problem hiding this comment.
Pull request overview
This PR prevents the receiver from reporting state="connected" during early SYSTEM_VOLUME_CHANGED events (before a SendspinPlayer exists), avoiding premature “app started successfully” signals to Music Assistant.
Changes:
- In the CAF receiver path, send
state: "connecting"(instead of"connected") when only a volume update is available and no player exists yet. - Apply the same adjustment in the legacy Cast Receiver API path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cast SDK fires
SYSTEM_VOLUME_CHANGEDat startup, before anySendspinPlayerexists. With that, the handler was sending status with state="connected" alongside the volume payload, causing Music Assistant to think that the App successfully started.