Play announcement on incompatible GC4A 2.0 devices#81
Merged
Conversation
GC4A 2.0-based devices lack AudioContext. Play a spoken error message via HTML5 Audio before triggering the fatal error flow.
setTimeout in ensureAudioContextSupported was never cleared when the audio's onended/onerror handler fired first, leaving a 15s timer with a held closure reference. Stash the timer id and clearTimeout in the shared finish handler.
There was a problem hiding this comment.
Pull request overview
Adds an audible “device not compatible with Sendspin” announcement path for Cast receivers that lack AudioContext (notably GC4A 2.0), then proceeds through the existing fatal-error shutdown flow.
Changes:
- Import an
error-incompatible.mp3asset and play it whenAudioContextis unavailable. - Convert
ensureAudioContextSupported()toasyncand await it during server connection. - Preserve existing fatal shutdown behavior after the announcement attempt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Play a "This device is not compatible with Sendspin." announcement when
AudioContextisn't available.This is specifically targeting Cast devices based on GC4A 2.0. Compared to the other cast runtimes it has no APIs that allow synchronized playback, which is required for this Cast App.