-
Notifications
You must be signed in to change notification settings - Fork 106
[WIP] Add Qwen3.5 h200 MTP #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hshrivastava-droid
wants to merge
4
commits into
main
Choose a base branch
from
nv/h200-qwen35
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+120
−9
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| source "$(dirname "$0")/../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME \ | ||
| EP_SIZE | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| nvidia-smi | ||
|
|
||
| hf download "$MODEL" | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
| PORT=${PORT:-8888} | ||
| MAX_SEQ_LEN=$((ISL + OSL + 20)) | ||
|
|
||
| echo "CONC: $CONC, ISL: $ISL, OSL: $OSL, MAX_SEQ_LEN: $MAX_SEQ_LEN" | ||
|
|
||
| # Start GPU monitoring (power, temperature, clocks every second) | ||
| start_gpu_monitor | ||
|
|
||
| set -x | ||
| python3 -m sglang.launch_server \ | ||
| --model "$MODEL" \ | ||
| --host 0.0.0.0 \ | ||
| --port "$PORT" \ | ||
| --tp "$TP" \ | ||
| --expert-parallel-size "$EP_SIZE" \ | ||
| --reasoning-parser qwen3 \ | ||
| --tool-call-parser qwen3_coder \ | ||
| --enable-flashinfer-allreduce-fusion \ | ||
| --max-running-requests 128 \ | ||
| --chunked-prefill-size 16384 \ | ||
| --decode-log-interval 1 \ | ||
| --mem-fraction-static 0.8 \ | ||
| --cuda-graph-max-bs "$CONC" \ | ||
| --context-length "$MAX_SEQ_LEN" \ | ||
| --kv-cache-dtype fp8_e4m3 \ | ||
| --quantization fp8 \ | ||
| --attention-backend flashinfer \ | ||
| --stream-interval 50 \ | ||
| --tokenizer-worker-num 6 \ | ||
| --mamba-ssm-dtype bfloat16 \ | ||
| --disable-radix-cache \ | ||
| --trust-remote-code \ | ||
| --speculative-algorithm EAGLE \ | ||
| --speculative-num-steps 2 \ | ||
| --speculative-num-draft-tokens 3 \ | ||
| --speculative-eagle-topk 1 \ | ||
| > "$SERVER_LOG" 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| pip install -q datasets pandas | ||
|
|
||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts "$((CONC * 10))" \ | ||
| --max-concurrency "$CONC" \ | ||
| --use-chat-template \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" --concurrent-requests $CONC | ||
| append_lm_eval_summary | ||
| fi | ||
|
|
||
| # Stop GPU monitoring | ||
| stop_gpu_monitor | ||
| set +x | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The
run_benchmark_servingcall is missing--use-chat-template, which every other MTP benchmark script in the repo (6 out of 6) includes. Without this flag, MTP acceptance rates are artificially high because raw text without chat formatting special tokens is easier for the draft model to predict, producing misleading benchmark results. Add--use-chat-templateafter the--result-dirline to match the established pattern.Extended reasoning...
What the bug is
The new
qwen3.5_fp8_h200_mtp.shbenchmark script omits--use-chat-templatefrom itsrun_benchmark_servingcall (lines 69-79). This flag is present in every other MTP benchmark script in the repository.Evidence of the pattern
All 6 existing single-node MTP benchmark scripts include
--use-chat-template:dsr1_fp8_b200_mtp.sh(line 108)dsr1_fp4_b200_trt_mtp.sh(line 133)dsr1_fp8_b200_trt_mtp.sh(line 143)dsr1_fp8_h200_trt_mtp.sh(line 115)dsr1_fp4_mi355x_atom_mtp.sh(line 71)dsr1_fp8_mi355x_atom_mtp.sh(line 70)Additionally, the multi-node AMD utility (
bench.sh:60) adds this flag generically for ALL MTP benchmarks via[ "$IS_MTP" = "true" ] && echo "--use-chat-template", confirming this is a model-agnostic requirement, not DeepSeek-specific.Root cause
The script was likely copied from the non-MTP
qwen3.5_fp8_h200.sh(which correctly omits the flag since MTP acceptance rates are irrelevant without speculative decoding) but failed to add--use-chat-templateas all other MTP scripts do.Step-by-step proof of impact
--speculative-algorithm EAGLE, lines 55-58).run_benchmark_servingsends prompts to the server. Without--use-chat-template, raw text is sent without chat formatting special tokens.<|im_start|>,<|im_end|>, etc.).How to fix
Add
--use-chat-templateto therun_benchmark_servingcall, e.g. after--result-dir /workspace/. This is a one-line addition that aligns the script with every other MTP benchmark in the repository.