-
Notifications
You must be signed in to change notification settings - Fork 224
Refresh DeepSeek-V4-Pro GB200 Dynamo vLLM stack / 更新 DeepSeek-V4-Pro GB200 Dynamo vLLM 推理栈 #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,12 +18,12 @@ name: "svf-vllm-disagg-gb200-high-tpt-megamoe" | |
| # absorb cold-cache /mnt/numa1 model loads. | ||
| model: | ||
| path: "deepseek-v4-pro" | ||
| container: "vllm/vllm-openai:v0.20.0-ubuntu2404" | ||
| container: "vllm/vllm-openai:dsv4-megamoe-mxfp4-arm64-cu130-4ba0a72" | ||
| precision: "fp4" | ||
|
|
||
| dynamo: | ||
| install: true | ||
| wheel: "1.2.0.dev20260426" | ||
| wheel: "1.3.0.dev1" | ||
|
Comment on lines
20
to
+26
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Documentation drift across all 5 modified GB200 recipes: both the 'Local deltas vs upstream' header comment (lines ~13-16, referencing Extended reasoning...What is staleEach of the 5 modified recipes has two documentation surfaces that the PR should have kept in sync with the 1. Header comment ( This comment is the load-bearing documentation of a local-delta invariant (AGENTS.md: 2. identity:
container:
image: "vllm/vllm-openai:v0.20.0-ubuntu2404"
frameworks:
dynamo: "1.2.0.dev20260426"
vllm: "0.20.0"Sibling recipe Step-by-step proof (using disagg-gb200-high-tpt-megamoe.yaml)
ImpactNo runtime effect — the benchmark reads from The concern is that any reviewer or downstream tool that trusts How to fixMechanical text replacement in the 5 affected files:
Severity is |
||
|
|
||
| setup_script: vllm-container-deps.sh | ||
|
|
||
|
|
@@ -48,11 +48,14 @@ infra: | |
|
|
||
| frontend: | ||
| type: dynamo | ||
| enable_multiple_frontends: false | ||
| enable_multiple_frontends: true | ||
| env: | ||
| DYN_REQUEST_PLANE_CODEC: "msgpack" | ||
| backend: | ||
| type: vllm | ||
| connector: null | ||
| prefill_environment: | ||
| DYN_REQUEST_PLANE_CODEC: "msgpack" | ||
| TILELANG_CLEANUP_TEMP_FILES: "1" | ||
| VLLM_USE_NCCL_SYMM_MEM: "1" | ||
| TORCH_SYMMMEM: "NVSHMEM" | ||
|
|
@@ -70,6 +73,7 @@ backend: | |
| UCX_CUDA_IPC_ENABLE_MNNVL: "y" | ||
| NCCL_P2P_LEVEL: NVL | ||
| decode_environment: | ||
| DYN_REQUEST_PLANE_CODEC: "msgpack" | ||
| TILELANG_CLEANUP_TEMP_FILES: "1" | ||
| VLLM_USE_NCCL_SYMM_MEM: "1" | ||
| TORCH_SYMMMEM: "NVSHMEM" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 WARNING: Incomplete stack refresh — the
identity:block at the bottom of this file (lines 147–155) still pins the old stack, whilemodel.containeranddynamo.wheelhere were updated.Why it matters:
identity.container.imagestill saysvllm/vllm-openai:v0.20.0-ubuntu2404andidentity.frameworks.dynamostill says1.2.0.dev20260426, contradicting the stack that actually runs (dsv4-megamoe-mxfp4-arm64-cu130-4ba0a72/1.3.0.dev1). Every other dsv4 recipe keeps these fields in sync with the top-level ones (e.g.disagg-gb200-low-latency-mtp2.yamllines 10/131), so anything consuming this block for provenance will attribute the new benchmark numbers to the old image and wheel.Fix: Update the identity block to match:
identity.frameworks.vllm: "0.20.0"is also likely stale for the new dev image — please confirm what vLLM version4ba0a72ships and update accordingly.This same stale
identity:block exists in all five modified recipes (same lines):disagg-gb200-high-tpt-megamoe.yaml,disagg-gb200-low-latency.yaml,disagg-gb200-low-middle-curve.yaml,disagg-gb200-max-tpt-megamoe.yaml,disagg-gb200-mid-curve-megamoe.yaml. The header comment at line 13 of each file ("model.container set to vllm/vllm-openai:v0.20.0-ubuntu2404 to match nvidia-master.yaml") is also stale — worth fixing in the same pass since it documents the master-config-match invariant this PR relies on.Fix this →