Skip to content

claude code vibe fix(export): render Monocraft font in minecraft mode PNG export #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
functionstackx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

claude code vibe fix(export): render Monocraft font in minecraft mode PNG export #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions packages/app/src/hooks/useChartExport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,21 +95,6 @@ function resolveCssVarsForExport(root: HTMLElement) {
}
}

/** Collect @font-face rules from all accessible stylesheets */
function getFontEmbedCSS(): string {
const fontFaces: string[] = [];
for (const sheet of document.styleSheets) {
try {
for (const rule of sheet.cssRules || []) {
if (rule instanceof CSSFontFaceRule) fontFaces.push(rule.cssText);
}
} catch {
// skip CORS-restricted stylesheets
}
}
return fontFaces.join('\n');
}

/** Wait for a React re-render to flush */
function waitForRender(): Promise<void> {
return new Promise((resolve) => {
Expand Down Expand Up @@ -369,15 +354,16 @@ export function useChartExport({
});
}

// Capture chart image
// Don't pass `fontEmbedCSS`: raw `@font-face` rules keep relative URLs that
// can't resolve inside an SVG data URL. Letting html-to-image run its own
// `getWebFontCSS` inlines the woff2 as a data URL, so Monocraft renders.
const { toPng } = await htmlToImagePromise;
const chartDataUrl = await toPng(exportElement, {
quality: 1,
pixelRatio: 2,
backgroundColor: bgColor,
cacheBust: true,
skipFonts: false,
fontEmbedCSS: getFontEmbedCSS(),
preferredFontFormat: 'woff2',
filter: (node) => !node.classList?.contains('no-export'),
style: {
Expand Down
Loading