Skip to content

claude code vibe feat(nudges): unified registry-driven nudge framework #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
functionstackx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

claude code vibe feat(nudges): unified registry-driven nudge framework #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/csv-export.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('CSV Export', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="chart-figure"]').should('exist');
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/custom-user-values.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const selectCustomPowerMetric = () => {
describe('Custom User Values', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="model-selector"]').should('be.visible');
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/drill-down-trend.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
describe('Drill-Down Trend Chart Modal', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
// Wait for scatter graph to render with data points
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/dropdown-switching.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
describe('Dropdown one-click switching', () => {
beforeEach(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="inference-chart-display"]').should('exist');
Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/evaluation-chart.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('Evaluation Chart', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/evaluation');
cy.get('[data-testid="evaluation-chart-display"]').should('exist');
Expand Down Expand Up @@ -43,7 +43,7 @@ describe('Evaluation Chart', () => {
describe('Evaluation Chart — Content & Interactions', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/evaluation');
cy.get('[data-testid="evaluation-chart-display"]').should('be.visible');
Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/gpu-power.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('PowerX', () => {
beforeEach(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
});
Expand All @@ -34,7 +34,7 @@ describe('PowerX', () => {
beforeEach(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
win.localStorage.setItem('inferencex-feature-gate', '1');
},
});
Expand Down
10 changes: 5 additions & 5 deletions packages/app/cypress/e2e/gpu-specs.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('GPU Specs Tab', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/gpu-specs');
// Wait for GPU Specs tab content to be present in the DOM
Expand Down Expand Up @@ -210,7 +210,7 @@ describe('GPU Specs Tab', () => {
describe('GPU Specs Bar Chart View', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/gpu-specs');
cy.get('h2').contains('GPU Specifications').should('exist');
Expand Down Expand Up @@ -284,7 +284,7 @@ describe('GPU Specs Bar Chart View', () => {
describe('GPU Specs Radar Chart View', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/gpu-specs');
cy.get('h2').contains('GPU Specifications').should('exist');
Expand Down Expand Up @@ -381,7 +381,7 @@ describe('GPU Specs Radar Chart View', () => {
describe('GPU Specs Navigation', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="chart-section-tabs"]').should('be.visible');
Expand All @@ -397,7 +397,7 @@ describe('GPU Specs Navigation', () => {
describe('Topology Dialog Navigation', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/gpu-specs');
cy.get('h2').contains('GPU Specifications').should('exist');
Expand Down
8 changes: 4 additions & 4 deletions packages/app/cypress/e2e/gradient-labels.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ describe('Gradient Labels Toggle', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
// Wait for chart to load
Expand Down Expand Up @@ -80,7 +80,7 @@ describe('Gradient Labels Toggle', () => {
it('URL param i_gradlabel=1 enables gradient labels on load', () => {
cy.visit('/inference?i_gradlabel=1', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand All @@ -90,7 +90,7 @@ describe('Gradient Labels Toggle', () => {
it('URL param i_advlabel=1 enables parallelism labels on load', () => {
cy.visit('/inference?i_advlabel=1', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down Expand Up @@ -119,7 +119,7 @@ describe('Gradient Labels with non-default Y-axis metrics', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/historical-trends.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
describe('Historical Trends Tab', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/historical');
cy.get('[data-testid="historical-trends-display"]').should('be.visible');
Expand Down Expand Up @@ -37,7 +37,7 @@ describe('Historical Trends Tab', () => {
describe('Historical Trends — Content & Interactions', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/historical');
cy.get('[data-testid="historical-trends-display"]').should('be.visible');
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/inference-chart.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('Inference Chart', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
});
Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/line-labels.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ describe('Line Labels Toggle', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
// Wait for chart to load
Expand Down Expand Up @@ -69,7 +69,7 @@ describe('Line Labels Toggle', () => {
it('URL param i_linelabel=1 enables line labels on load', () => {
cy.visit('/inference?i_linelabel=1', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/model-architecture.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ describe('Model Architecture Diagram', () => {
cy.viewport(1280, 800);
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
// Wait for the page to load
Expand Down
8 changes: 4 additions & 4 deletions packages/app/cypress/e2e/navigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
describe('Chart Section Tabs — E2E', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
});
Expand Down Expand Up @@ -46,15 +46,15 @@ describe('First-load navigation', () => {
cy.visit('/', {
onBeforeLoad(win) {
win.localStorage.removeItem('inferencex-starred');
win.localStorage.removeItem('inferencex-star-modal-dismissed');
win.localStorage.removeItem('inferencex-dsv4-modal-dismissed');
win.localStorage.removeItem('inferencex-nudge:github-star-modal');
win.localStorage.removeItem('inferencex-nudge:dsv4-launch-modal');
},
});

// dsv4 launch modal takes precedence over the GitHub star modal on first
// load — only one modal shows at a time. Either is fine for this test, we
// just need *a* first-load modal up to verify it doesn't block navigation.
cy.get('[data-testid="dsv4-launch-modal"]').should('be.visible');
cy.get('[data-testid="nudge-dsv4-launch-modal"]').should('be.visible');
cy.get('body').should('not.have.attr', 'data-scroll-locked');
});

Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/reliability-chart.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('Reliability Chart', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/reliability');
cy.get('[data-testid="reliability-chart-display"]').should('exist');
Expand Down Expand Up @@ -49,7 +49,7 @@ describe('Reliability Chart', () => {
describe('Reliability Chart — Content & Interactions', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/reliability');
cy.get('[data-testid="reliability-chart-display"]').should('be.visible');
Expand Down
4 changes: 2 additions & 2 deletions packages/app/cypress/e2e/sanity.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('Page Load & Navigation', () => {
it('navigates from the footer to the land acknowledgement page', () => {
cy.visit('/', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});

Expand Down Expand Up @@ -66,7 +66,7 @@ describe('Page Load & Navigation', () => {
describe('Theme Toggle', () => {
it('theme persists across page reload (localStorage)', () => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
win.localStorage.setItem('theme', 'light');
});
cy.visit('/');
Expand Down
10 changes: 5 additions & 5 deletions packages/app/cypress/e2e/speed-overlay.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ describe('Bus / Race Car Speed Overlay', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down Expand Up @@ -55,7 +55,7 @@ describe('Bus / Race Car Speed Overlay', () => {
it('URL param i_speed=1 enables the overlay on first load', () => {
cy.visit('/inference?i_speed=1', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand All @@ -69,7 +69,7 @@ describe('Donkey / Elytra Minecraft Overlay', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down Expand Up @@ -129,7 +129,7 @@ describe('Donkey / Elytra Minecraft Overlay', () => {
it('URL param i_mc=1 enables the minecraft overlay on first load', () => {
cy.visit('/inference?i_mc=1', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand All @@ -146,7 +146,7 @@ describe('Y-Axis Metric Search', () => {
before(() => {
cy.visit('/inference', {
onBeforeLoad(win) {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
},
});
cy.get('[data-testid="scatter-graph"]').should('be.visible');
Expand Down
6 changes: 3 additions & 3 deletions packages/app/cypress/e2e/throughput-calculator.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('TCO Calculator', () => {
describe('tab navigation', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
});
Expand Down Expand Up @@ -37,7 +37,7 @@ describe('TCO Calculator', () => {
describe('controls, interactions, and features', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/calculator');
cy.get('[data-testid="calculator-bar-chart"] svg .bar').should('have.length.greaterThan', 0);
Expand Down Expand Up @@ -514,7 +514,7 @@ describe('TCO Calculator', () => {
describe('direct URL navigation', () => {
it('navigating to /calculator directly loads the calculator tab with data', () => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/calculator');
cy.url().should('include', '/calculator');
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/ttft-x-axis-toggle.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('TTFT X-Axis Toggle (E2E chart)', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="chart-figure"]').should('have.length.at.least', 2);
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/url-params.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
describe('URL Parameter Persistence', () => {
before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/yaxis-metrics-render.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Y-Axis Metrics All Render Data', () => {

before(() => {
cy.window().then((win) => {
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
win.localStorage.setItem('inferencex-nudge:github-star-modal', String(Date.now()));
});
cy.visit('/inference');
cy.get('[data-testid="scatter-graph"]')
Expand Down
2 changes: 0 additions & 2 deletions packages/app/src/app/(dashboard)/evaluation/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { Metadata } from 'next';

import { EvalSamplesNudge } from '@/components/eval-samples-nudge';
import { EvaluationProvider } from '@/components/evaluation/EvaluationContext';
import EvaluationChartDisplay from '@/components/evaluation/ui/ChartDisplay';
import { tabMetadata } from '@/lib/tab-meta';
Expand All @@ -11,7 +10,6 @@ export default function EvaluationPage() {
return (
<EvaluationProvider>
<EvaluationChartDisplay />
<EvalSamplesNudge />
</EvaluationProvider>
);
}
Loading
Loading