Open
Conversation
In step 7 for Python, the code block is missing line 18 which creates the message variable. This way people that are following along the `"getting_started"` tutorial won't be as confused.
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
Contributor
PR Reviewer Guide 🔍
|
Contributor
PR Code Suggestions ✨No code suggestions found for PR. |
Author
|
Found this error since I was trying to do the tutorial myself for the first time. |
harsha509
requested changes
Jul 9, 2024
Member
harsha509
left a comment
There was a problem hiding this comment.
HI @darrenqchen ,
Thank you for the PR.
Your feedback is indeed beneficial in our efforts towards refining and enhancing our documentation.
To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages (pt-br, zh-cn, ja)?
If you need any assistance or prefer me to implement the changes, kindly let me know.
Thanks,
Sri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
In step 7 for Python, the code block is missing line 18 from
examples/python/tests/getting_started/first_script.pywhich creates themessagevariable. This way people that are following along the"getting_started"tutorial won't be as confused.Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Documentation
Description
messagevariable creation is visible.Changes walkthrough 📝
first_script.en.md
Fix missing line in Python code block for tutorialwebsite_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
messagevariable is included in thetutorial.