Skip to content
This repository was archived by the owner on May 20, 2020. It is now read-only.

Update context list information#7

Open
imurchie wants to merge 1 commit intoSeleniumHQ:masterfrom
imurchie:isaac-contexts
Open

Update context list information#7
imurchie wants to merge 1 commit intoSeleniumHQ:masterfrom
imurchie:isaac-contexts

Conversation

@imurchie
Copy link
Contributor

It is often the case that there are multiple webview contexts in an application under test. If all that is returned in the list of contexts is the id of each webview, it necessitates switching into each one to distinguish them. Since context switching is, in practical terms, an expensive and error-prone operation, giving as much information at the offset is preferrable.

Copy link
Contributor

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is a good idea

@lukeis
Copy link
Member

lukeis commented Aug 29, 2017

i like the idea, since it is a frequent use case to need the current location of the webview. But this muddies the end client's API a bit. Can you show examples of how you'd anticipate API touch points to look?

Currently the return type for getWindowHandles in Java (and other client bindings) is a Set.

http://seleniumhq.github.io/selenium/docs/api/java/org/openqa/selenium/WebDriver.html#getWindowHandles--

@lukeis
Copy link
Member

lukeis commented Aug 29, 2017

same goes with getContextHandles from appium java-client -
https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/AppiumDriver.java#L220

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants