Open
Conversation
Added sprite_flip.rs and tilemap_flip.rs in examples as well. The sprite_flip appears to work well. The tilemap_flip seems to work for x-axis flip but not y-axis.
Owner
|
Nice, thank you. I will take a closer look at this soon.
Fair, yeah, it's kind of a mess of math |
Seldom-SE
requested changes
Jan 15, 2025
Owner
Seldom-SE
left a comment
Seldom-SE
left a comment
There was a problem hiding this comment.
Thanks! If you do these things and get CI to pass, I'll merge
| } | ||
|
|
||
| pub(crate) type TileComponents = (&'static PxTile, Option<&'static PxFilter>); | ||
| pub(crate) type TileComponents = (&'static PxTile, Option<&'static PxFilter>, Option<&'static PxFlip>); |
Owner
There was a problem hiding this comment.
Make this non-optional and add PxFlip as a required component on PxTile
| &'static PxCanvas, | ||
| Option<&'static PxAnimation>, | ||
| Option<&'static PxFilter>, | ||
| Option<&'static PxFlip>, |
Owner
There was a problem hiding this comment.
Same as earlier comment, but for PxSprite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sprite_flip.rs and tilemap_flip.rs in examples as well. The sprite_flip appears to work well. The tilemap_flip seems to work for x-axis flip but not y-axis.
I did not add any flip for text because I wasn't even sure what it might mean and it looked complicated.