Support unaligned tensor memory allocation for PETSc compatibility #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The changes allow to enforce that Tensors use unaligned memory instead of relying on the default logic of yateto (that assumes that all power-of-vector-size tensors are aligned). IIRC it is used in tandem as alignment is a compile-time setting in PETSc, cf https://github.com/TEAR-ERC/tandem/blob/main/app/kernels/generate.py#L30 |
Thomas-Ulrich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it make sense to merge this code?
I just merged the content of the branch new_alignement_mode, used by tandem, with yateto.
No idea what it is useful for ;-)