-
Notifications
You must be signed in to change notification settings - Fork 3
Add periodic mesh support for GMSH; format everything a bit #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
with kubuntu 24, I get: maybe it could be worth using an older rev v0.13.0? EDIT: could update nvm with but do we want to force developers to do this update for a linter?
Is this language_version specifier really necessary? |
Thomas-Ulrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See also the 2 comments about precommits.
|
Thanks for the feedback! Regarding the pre-commit comments:
(all of these changes to the pre-commit config will also need to be propagated to SeisSol and a PSpaMM PR probably) |
|
ok then forget about the |
third_partyfolder).