Merged
Conversation
| private: | ||
| EasiMeshSize easiMeshSize; | ||
| std::shared_ptr<EasiMeshSize> easiMeshSize; | ||
| pGModel m_model; |
Contributor
There was a problem hiding this comment.
This reminds me if we want to also adapt all the naming conventions here for these repositories too.
Contributor
Author
There was a problem hiding this comment.
How do you mean?
If it's about applying clang-tidy to absolutely everything: in principle, yes—absolutely.
(and yes, it's still missing for PUMgen so far)
Contributor
There was a problem hiding this comment.
How do you mean?
If it's about applying
clang-tidyto absolutely everything: in principle, yes—absolutely.
This, exactly. the variable name m_model just brought the question up in my head.
(and yes, it's still missing for PUMgen so far)
Contributor
Author
There was a problem hiding this comment.
Definitely. Also, PUMgen should be really easy to adjust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #53