Allow custom board variants based on this core#12
Merged
StarSphere-1024 merged 1 commit intoSeeed-Studio:masterfrom Feb 26, 2026
Merged
Conversation
MatthewJeffson
added
Adafruit_nRF52_Arduino
StarSphere-1024
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new boards should be possible without changing the core itself. The Arduino Platform Specification documents the ability to create custom board variants that reference this core and it would be great if we could do that with the Seeeduino core. Line 84 of main.cpp, unfortunately, makes this impossible.
https://github.com/Seeed-Studio/Adafruit_nRF52_Arduino/blob/master/cores/nRF5/main.cpp#L84:
The suggested change is to restore the default parameters, yet still allow the exceptions (board variants such as the ARDUINO_WIO_TRACKER_1110 that do need to modify the core directly). There may be better ways to accomplish that exceptional change, but that is not the scope of this pull request
The limited code and changes provided in this pull request are provided freely and completely to the Seeed-Studio project to be used as its maintainers see fit and under any copyright they deem appropriate.