[Cleanup] Remove unnecessary CameraConnectionError error message#859
Merged
newtonick merged 1 commit intoSeedSigner:devfrom Jan 17, 2026
Merged
Conversation
Collaborator
|
ACK |
newtonick
moved this from 0.8.7 Needs Code Review
to 0.8.7 Merged
in @SeedSigner Development Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
CameraConnectionErroris raised, the exception handler routes users to the newCameraConnectionErrorView. That View then has its own text to guide the user to resolve the issue.The error message defined in
CameraConnectionErroris never presented to the user and does not provide any useful debugging into for devs.Worse, the unnecessary error message is marked for translation. Obviously there's no need to create additional translation burden on a string that is never presented to the user.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: