Skip to content

Conversation

@newtonick
Copy link
Collaborator

@newtonick newtonick commented Oct 24, 2025

Dependency on SeedSigner/seedsigner-translations#48. No not merge until SeedSigner/seedsigner-translations#48 is merged first.

Description

This pull requests is related to at least 2 other other pull requests. One in the seedsigner-translations repo and the other in the seedsigner-os repo.

Related pull requests:

seedsigner-translations repo: SeedSigner/seedsigner-translations#48
seedsigner-os repo: SeedSigner/seedsigner-os#98

The objective of these 3 pull requests is:

  • Move the large foreign language font files from the seedsigner app repo to the translation repo (a submodule in the app repo)
  • Update the build script to include slimed down versions the foreign language font files that only include the character set used in seedsigner-translations. This should allow the final image to be 15MB smaller than it is today.

This pull request makes these changes:

This pull request makes these changes:

  • File refactor
  • Feature

Checklist

  • I’ve run pytest and made sure all unit tests pass before submitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 0.8.7 Needs Code Review

Development

Successfully merging this pull request may close these issues.

1 participant