[Feature] Move foreign font files to seedsigner-translations repo #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency on SeedSigner/seedsigner-translations#48. No not merge until SeedSigner/seedsigner-translations#48 is merged first.
Description
This pull requests is related to at least 2 other other pull requests. One in the seedsigner-translations repo and the other in the seedsigner-os repo.
Related pull requests:
seedsigner-translations repo: SeedSigner/seedsigner-translations#48
seedsigner-os repo: SeedSigner/seedsigner-os#98
The objective of these 3 pull requests is:
This pull request makes these changes:
components.pyto load fonts from the originalsrc/seedsigner/resources/fontslocation and also the additional locationsrc/seedsigner/resources/seedsigner-translations/fonts.This pull request makes these changes:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.