Fix Python 3.12+ compatibility by replacing imp with importlib#213
Open
jalovisko wants to merge 1 commit intoSebKuzminsky:masterfrom
Open
Fix Python 3.12+ compatibility by replacing imp with importlib#213jalovisko wants to merge 1 commit intoSebKuzminsky:masterfrom
jalovisko wants to merge 1 commit intoSebKuzminsky:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like PyCAM was developed while Python 3.4 was around, but it reached end-of-life and is no longer supported. The changes needed for it to work, however, are minimal, and are introduced in this pull request.
Summary of changes:
impmodule withimportlib.utilin plugin system. Theimpmodule was deprecated in Python 3.4 and removed in Python 3.12. This PR updates the plugin loading system inpycam/Plugins/__init__.pyto use the modernimportlib.utilAPI instead.Tested on Arch Linux with Python 3.13.7 in a virtualenv with
--system-site-packages.This solves issue #191, it was originally thought that requirements are incomplete, but in reality some dependencies of base Python are not around anymore in newer versions.