Open
Conversation
OpenSCAD handle circles as polygon. setting a high enough number of polygon and a small enough diameter generate really small, but non null, lines.
Contributor
|
Why is the check for zero-length/short-lengh lines removed? It seem a bit risky. |
Author
|
the check is removed because models produced in openscad with high $fn, like |
Contributor
|
[SEINLET Nicolas]
the check is removed because models produced in openscad with high
$fn, like `$fn = 200;cylinder(r=2,h=10,center=true);` are unusable in
pycam.
Aha. Why not reduce the epsilon instead? I assume the length is not
zero?
…--
Happy hacking
Petter Reinholdtsen
|
Contributor
|
[SEINLET Nicolas]
the check is removed because models produced in openscad with high
$fn, like `$fn = 200;cylinder(r=2,h=10,center=true);` are unusable in
pycam.
What exactly is the line length with such $fn here?
I find 'epsilon = 0.00001' in pycam/Geometry/__init__.py. If I
understand the cylinder correctly, it got radius 2 and the circle will
be split into 200 segments. Each segment would them be approximately
2 * 3.14159 * 2 /200 = .0628318, which is way above epsilon. Did I
misunderstand the issue?
…--
Happy hacking
Petter Reinholdtsen
|
Contributor
|
@nseinlet Btw, do you have an example STL file demonstrating the problem, and perhaps the openscad file used to generate it? |
Author
|
I'll reproduce the issue and upload file and Traceback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 small improvements I use daily to handle stl which comes out of openscad designs.