This repository was archived by the owner on Oct 8, 2025. It is now read-only.
171-sprint24-requestpage_component_enhancement#174
Open
MiguelQuintana1 wants to merge 2 commits intomainfrom
Open
171-sprint24-requestpage_component_enhancement#174MiguelQuintana1 wants to merge 2 commits intomainfrom
MiguelQuintana1 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #171
GMT20250616-045358_Clip_Miguel.Quintana.s.Clip.06_15_2025.mp4
Key Changes:
Introduced CustomDropdown.tsx Component:
Created a new reusable CustomDropdown component to encapsulate the dropdown logic and styling.
This component utilizes TouchableOpacity for the main button, a Modal for the overlay, and a FlatList to efficiently render the selectable options.
It includes a visual chevron icon (from @expo/vector-icons) for better affordance.
Styling is consistent with existing form elements, providing a polished and integrated look.
Replaced TextInput with CustomDropdown in RequestPage.tsx:
The previous TextInput for "Hours Off" was removed and replaced with an instance of the new CustomDropdown component.
The hoursOffOptions array now strictly defines the allowed time-off choices: "Full Day", "Half Day", "1 Hour", "2 Hours", "3 Hours", "4 Hours", "5 Hours", "6 Hours", "7 Hours", and "8 Hours".
Updated Form Validation:
The handleSubmit function in RequestPage.tsx was updated to correctly validate the hoursOff selection from the custom dropdown, ensuring a value is chosen before submission.
The isFormValid check also now correctly accounts for the dropdown's selected value.
How to Test 🧪