Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Adding update caret to react-navigation/native#173

Open
TVW96 wants to merge 3 commits intomainfrom
fix-depndecy-update-bottom-tabs-upd-to-date
Open

Adding update caret to react-navigation/native#173
TVW96 wants to merge 3 commits intomainfrom
fix-depndecy-update-bottom-tabs-upd-to-date

Conversation

@TVW96
Copy link
Copy Markdown

@TVW96 TVW96 commented Jun 16, 2025

Summary & Changes 📃

Noticed the issue occurring here in this commit 4f63c1b was that the specific version of natives was stopping the main app features page from loading. You can see the screen shot in my comment on the commit.

To fix this change we have to allow for patch updates of the @react-navigation/natives dependency. Not sure exactly which version of the dependency is needed but that doesn't matter if we leave the caret.

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: Install the app
    • Step 2: Run the app in mobile environment
    • Step 3: Click the first link on the home page to make sure that the (tabs)/_layout.tsx page is still loading.

@TVW96 TVW96 requested review from IsaacJrTypes, Copilot and nwm516 June 16, 2025 03:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to allow patch updates for dependencies by introducing caret (^) version specifiers.

  • Changed @react-native-async-storage/async-storage to use a caret specifier.
  • Ensures dependencies can receive non-breaking updates automatically.
Comments suppressed due to low confidence (1)

package.json:37

  • Consider adding a caret prefix to this dependency (e.g., "^7.2.0") to allow patch updates, matching the intent described in the PR and the pattern used for other dependencies.
"@react-navigation/bottom-tabs": "7.2.0",

@TVW96 TVW96 changed the title Adding update caret to react-navigation/bottom-tabs Adding update caret to react-navigation/native Jun 16, 2025
Copy link
Copy Markdown
Contributor

@MiguelQuintana1 MiguelQuintana1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if this is related to this issue, but in the tab, in the las component the app breaks, i tried that from main and seems to have the same problem. i'm just wondering if you have the same problem or not?

GMT20250616-050726_Clip_Miguel.Quintana.s.Clip.06_15_2025.mp4

@IsaacJrTypes
Copy link
Copy Markdown
Contributor

@MiguelQuintana1 I was having the same issue on main, but don't worry about it since it's fixed in PR #150

@TVW96
Copy link
Copy Markdown
Author

TVW96 commented Jun 16, 2025

@MiguelQuintana1 I was having the same issue on main, but don't worry about it since it's fixed in PR #150

The calendar rework is an independent task that irrelevant to the current breaking change. Please approve the PR so we can fix the issues with main.

@TVW96 TVW96 requested a review from MiguelQuintana1 June 19, 2025 04:08
@TVW96 TVW96 self-assigned this Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants